Remove obsolete snapshot compatibility paths - #1715
Merged
ludfjig merged 1 commit intoAug 20, 2026
Merged
Conversation
ludfjig
added
the
kind/refactor
ludfjig
force-pushed
the
cleanup-snapshot-compatibility
branch
from
August 20, 2026 16:07
b9dd787 to
7839317
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
cleanup-snapshot-compatibility
branch
from
August 20, 2026 16:43
7839317 to
324b2fd
Compare
ludfjig
marked this pull request as ready for review
August 20, 2026 16:43
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
August 20, 2026 16:43
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two snapshot-loading compatibility fallbacks in hyperlight-host (missing msrs and original_entrypoint_addr == 0) now that snapshot format breakage is acceptable per #1654/#1674 context, and updates validation, tests, and documentation accordingly.
Changes:
- Make
original_entrypoint_addrrequired and reject0by validating it must be within the snapshot region. - Make
msrsrequired onx86_64by removing the missing-field serde fallback and updating tests to assert rejection. - Remove the completed “compatibility cleanup” notes from
docs/snapshot-versioning.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/hyperlight_host/src/sandbox/snapshot/file/config.rs |
Removes serde defaults and tightens validation around original_entrypoint_addr and msrs; updates related unit tests and schema pin data. |
src/hyperlight_host/src/sandbox/snapshot/file_tests.rs |
Updates on-disk mutation tests to expect load failures for missing msrs and original_entrypoint_addr == 0. |
docs/snapshot-versioning.md |
Drops now-applied compatibility-cleanup items from the versioning documentation. |
Suppressed comments (1)
src/hyperlight_host/src/sandbox/snapshot/file/config.rs:189
- The MSR comment says "An empty field" which reads like the key can be omitted, but the PR makes
msrsrequired on x86_64. Use wording that matches the serialized shape (array present, possibly empty) and call out that the field is required.
/// The MSRs saved in this snapshot. An empty field restores the destination
/// baseline.
#[cfg(target_arch = "x86_64")]
pub(super) msrs: Vec<MsrEntry>,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jsturtevant
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes optional MSR/original-elf-entrypoint snapshot loading path. This is correct because #1674 breaks all existing snapshot on disk, so we can do these breakign changes as well.
Will mark ready once #1674 is merged.
closes #1654